Skip to content

Fix errors in numeric binary decoder #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

Fix errors in numeric binary decoder #2

merged 1 commit into from
Jan 9, 2020

Conversation

sthagen
Copy link
Owner

@sthagen sthagen commented Jan 9, 2020

The size of the output buffer in numeric decoder is computed incorrectly
which may lead to stack corruption or access to unitialized memory.

This also fixes incorrect rendering of trailing zeros in some cases.

Fixes: MagicStack#520
Fixes: MagicStack#514

@elprans @1st1
Fix errors in numeric binary decoder
851d586 
The size of the output buffer in numeric decoder is computed incorrectly
which may lead to stack corruption or access to unitialized memory.

This also fixes incorrect rendering of trailing zeros in some cases.

Fixes: #520
Fixes: #514
@sthagen sthagen merged commit 323ff23 into sthagen:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when there are trailing zeros in numeric values Extra zero decimal digits after decoding NUMERIC (DECIMAL) type
2 participants
@sthagen @elprans